feat: activate arbitrum, avax, gnosis collateral swaps via cow adapters #2766
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mgrabina
force-pushed
the
feat/activate-l2s-cow-coll-swap
branch
from
8e2cfbc to
f0eab11
Compare
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mgrabina
force-pushed
the
feat/activate-l2s-cow-coll-swap
branch
from
b64f2c6 to
753499e
Compare
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| // For CollateralSwap, block if the user has any zero-LTV collateral enabled | ||
| if (state.swapType === SwapType.CollateralSwap) { | ||
| return blockingAssets.length > 0; | ||
| } |
There was a problem hiding this comment.
With the new swap-type-specific logic in hasZeroLTVBlocking, a user who triggers the zero-LTV guard while on a CollateralSwap and then switches to RepayWithCollateral (which this branch explicitly allows) will keep the previous ZeroLTVBlockingError and actionsBlocked state because the effect below only re-runs when assetsBlockingWithdraw or sourceToken change. In that scenario the UI continues to show a generic provider error and blocks the repay flow even though hasZeroLTVBlocking would now return false. Include state.swapType in the effect dependencies or otherwise clear the error on swap-type changes to avoid blocking permitted flows.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.